perf(tests): skip coverage on 3.13t - #1391
Merged
Merged
Conversation
Free-threaded 3.13 has no fast C tracer, so coverage is as slow as on PyPy. Replace the hardcoded PyPy check with a NO_COVERAGE default and a --coverage/--no-coverage flag for the tests session. Assisted-by: ClaudeCode:claude-opus-5
notatallshaw
approved these changes
Aug 16, 2026
Member
Well, because different versions of Python emit different bytecode, usually due to optimizations in the compiler, I have many times had to fix coverage on some versions of Python (usually on older versions) but not others. However, I don't think we should waste our, or CI's, time on 3.13t support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our 3.13t job is reallllly slow (8 mins on CI). This brings it in line with the others, under 2 mins. No need to check coverage on every job, they all report 100% (not combined later, in other words).
Also now support turning off (or on) coverage from nox.
(FWIW, here's the PyPy missing coverage:
)
🤖 AI text below 🤖
Free-threaded 3.13 has no fast C tracer, so coverage tracking there is as slow as on PyPy.
The hardcoded PyPy check in the
testssession becomes aNO_COVERAGEdefault (pypy,3.13t) plus a--coverage/--no-coverageflag, so any session can turn coverage on or off: