Tests: Open SVN dump file in binary mode to prevent UnicodeDecodeError #13670
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `_create_svn_initools_repo` in `tests/lib/local_repos.py` was opening a downloaded SVN dump file using the default text mode (`'r'`). Because SVN dump files contain binary data, this caused a `UnicodeDecodeError` on Windows and corrupted data due to newline translation when piping to `svnadmin`. This commit changes the `open()` call to use `'rb'` (binary mode) to ensure the raw bytes are passed to `svnadmin` correctly.
Contributor
Author
|
Thanks @uranusjr sir ❤️🙏
|
ichard26
added
the
skip news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a UnicodeDecodeError in tests/lib/local_repos.py that occurs on Windows when running SVN-related tests.
The Bug The function _create_svn_initools_repo downloads a binary SVN dump file (INITools_modified.dump) but opens it using the default text mode (open(filename)).
On Windows, this attempts to decode raw binary bytes using the default encoding (often CP1252 or UTF-8), causing a crash.
It also causes newline translation (\n -> \r\n), which corrupts the stream sent to svnadmin.
The Fix Changed the open() call to use binary mode ('rb') to ensure raw bytes are passed correctly to subprocess.
Verification Verified locally on Windows. The test code now successfully opens the file without crashing.
Fixes #13669