Bump Sphinx to v3.2.1 and fix docs build issues #8791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shireenrao
changed the title
McSinyx
approved these changes
Aug 20, 2020
Contributor
McSinyx
left a comment
McSinyx
left a comment
There was a problem hiding this comment.
My approval isn't authoritative but I would love to see this merged as soon as possible. I notice that the code blocks' background are no longer in asparagus color but I suppose it could wait for a follow-up.
eamanu
approved these changes
Aug 20, 2020
Contributor
Author
@McSinyx - Sphinx added background colors and text colors for code blocks as a theme option. I have added that to conf.py and tested locally. The colors are back. |
uranusjr
reviewed
Aug 22, 2020
uranusjr
approved these changes
Aug 24, 2020
Member
|
Let's see what CI says on master now. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #8781 build issues.