Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pipdeptree #5343

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Bump pipdeptree #5343

merged 3 commits into from
Sep 8, 2022

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Sep 8, 2022

This is required for enabling Python3.11

This package uses hatchling as a build backend and required special
case.
There should be a better way, but for now this works.
@cclauss
Copy link
Contributor

cclauss commented Sep 8, 2022

Perhaps add the changes from #5245 so that we are assured that the tests pass.

@oz123
Copy link
Contributor Author

oz123 commented Sep 8, 2022

Perhaps add the changes from #5245 so that we are assured that the tests pass.

I prefer doing this in a separate PR. Let's merge this one, and then one can merge the main branch to #5245 .

@oz123 oz123 merged commit f2206e0 into main Sep 8, 2022
@oz123 oz123 deleted the bump-pipdeptree branch September 8, 2022 14:35
@cclauss
Copy link
Contributor

cclauss commented Sep 8, 2022

After this was merged, I rebased the Python 3.11 tests in #5245 and they fail. :-(

@matteius
Copy link
Member

matteius commented Sep 8, 2022

Same failures?

@cclauss
Copy link
Contributor

cclauss commented Sep 8, 2022

It appears that the vendored-in pytest is trying to import tomli instead of using the tomllib that is built into Py3.11. https://docs.python.org/3.11/library/tomllib.html

Is the vendored-in pytest current? https://github.com/pytest-dev/pytest/releases

lib/python3.11/site-packages/_pytest/config/findpaths.py",
  line 67, in load_config_dict_from_file
    import tomli
ModuleNotFoundError: No module named 'tomli'

@cclauss cclauss mentioned this pull request Sep 8, 2022
2 tasks
@cclauss
Copy link
Contributor

cclauss commented Sep 8, 2022

This will need to wait until pytest v7.2.0
pytest-dev/pytest#9982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants