Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty namespace package wheel install #1861

Conversation

@benoit-pierre
Copy link
Member

benoit-pierre commented Oct 7, 2019

Summary of changes

Fix a corner case found with one of the tests when implementing #1830: handle installing a wheel with an empty namespace package.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@benoit-pierre benoit-pierre force-pushed the benoit-pierre:fix_empty_namespace_package_wheel_install branch from 66d58c4 to 16a3ef9 Oct 7, 2019
@benoit-pierre benoit-pierre reopened this Nov 13, 2019
@benoit-pierre benoit-pierre merged commit 705d41e into pypa:master Nov 13, 2019
6 checks passed
6 checks passed
Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 84.74%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +15.25% compared to 734d09c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_empty_namespace_package_wheel_install branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.