Skip to content

Refactored the wheel convert command to not require setuptools#640

Merged
agronholm merged 9 commits into
mainfrom
refactor-convert-command
Nov 8, 2024
Merged

Refactored the wheel convert command to not require setuptools#640
agronholm merged 9 commits into
mainfrom
refactor-convert-command

Conversation

@agronholm

Copy link
Copy Markdown
Contributor

This also aims to improve the correctness of the egg and bdist_wininst conversions.

Fixes #510.

This also aims to improve the correctness of the egg and bdist_wininst conversions.
@codecov

codecov Bot commented Nov 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.02273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (e43464d) to head (5b4a98c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/wheel/cli/convert.py 96.02% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   71.18%   77.96%   +6.78%     
==========================================
  Files          14       14              
  Lines        1093     1121      +28     
==========================================
+ Hits          778      874      +96     
+ Misses        315      247      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agronholm

Copy link
Copy Markdown
Contributor Author

Gotta say, I spent way too much time on this feature that probably no one will use anymore...

Comment thread tests/cli/test_convert.py Outdated

@henryiii henryiii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have a use for the command at the moment, but code looks reasonable.

@agronholm
agronholm merged commit c81f5c9 into main Nov 8, 2024
@agronholm
agronholm deleted the refactor-convert-command branch November 8, 2024 07:29
@agronholm

Copy link
Copy Markdown
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"wheel convert" depends on setuptools

2 participants