Hotfix noheader list #215
Merged
Hotfix noheader list #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needed in cases where there might be a leading whitespace
briochh
approved these changes
Jan 25, 2021
| pf.extra_py_imports.append('flopy') | ||
| pf.mod_sys_cmds.append("which python") | ||
| if "linux" in platform.platform().lower(): | ||
| pf.mod_sys_cmds.append("which python") |
Collaborator
There was a problem hiding this comment.
Think I just added this when I was having some pathing issues can probs be dropped if not useful.
Collaborator
|
@jtwhite79, Re rows that are not to be observationalized (love it.): I agree that skipping whole rows is best. I think that this speeds up the processing of those HUGE files when not all rows contain obs. Is this what is currently happening (i.e we write |
Collaborator
Author
|
Currently, each skipped row is getting a full compliment of so skipping those rows with just an |
Collaborator
|
double agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for whitespace delim list files with and without headers. Switched from
winstruction to!dum!instruction inpst_utils.csv_to_ins_file()for whitespace delim since it should be a safer option to guard against leading whitespace issues. Also relaxed the restriction that the!dum!entry in the output file be cast to double (this has also been changed in pest++ and I think pest will also make the change soon) - this helps with tables of mixed types that might not be numeric. Had to switch to thefeat_newtoolsbranch of pest++ to support this so we need to keep in mind to switch back todevelopat some point in the future. One thing Im still wondering about: for rows that are to be skipped in the output file, should we skip the row with just al1rather than filling out the row for all the markers and/or!dum!instructions? I think so but @briochh would know better.