Skip to content

feat: ani-sync on windows - #700

Merged
port19x merged 10 commits into
masterfrom
ani-sync-windows
May 5, 2022
Merged

feat: ani-sync on windows#700
port19x merged 10 commits into
masterfrom
ani-sync-windows

Conversation

@justchokingaround

@justchokingaround justchokingaround commented Apr 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Tested with a Windows User, works as expected

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • quality works
  • downloads work
  • quality works with downloads
  • select episode -a and rapid resume work
  • syncplay -s works
  • autoplay, aka range selection, works

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Not uploaded: one piece dub episode 590
  • Unreleased: soredemo ayumu wa yosetekuru
  • Short id (for decryption): Log Horizon episode 1-2

Derisis13
Derisis13 reviewed Apr 30, 2022
View reviewed changes
Comment thread ani-cli Outdated
Derisis13
Derisis13 requested changes Apr 30, 2022
View reviewed changes

@Derisis13 Derisis13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shall make a nice release once complete

Comment thread ani-cli Outdated
Comment thread ani-cli Outdated
@port19x

port19x commented May 1, 2022

Copy link
Copy Markdown
Collaborator

This shall make a nice release once complete

definitely

Derisis13
Derisis13 approved these changes May 2, 2022
View reviewed changes

@Derisis13 Derisis13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anyone to watch together though...

@port19x

port19x commented May 3, 2022

Copy link
Copy Markdown
Collaborator

I'd like to merge 707 first and then release this

@justchokingaround

justchokingaround commented May 3, 2022

Copy link
Copy Markdown
Collaborator Author

sounds good

@port19x port19x linked an issue May 4, 2022 that may be closed by this pull request
Long acces times #709
Closed
port19x
port19x reviewed May 4, 2022
View reviewed changes
Comment thread README.md
@port19x port19x mentioned this pull request May 4, 2022
Merged
3 tasks
@port19x

port19x commented May 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Release checklist

@port19x

port19x commented May 5, 2022

Copy link
Copy Markdown
Collaborator

We're very close to release. If possible I'd like to merge this this evening

@CoolnsX

CoolnsX commented May 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Wait wait.. we don't hv native package on termux yet..
I also read all those link u send but right now it's not in standard repos..
I checked it now and installed it.. but it's installing the standard mpv... Not the custom one we wrote in our documentation
Also it's an older version.. like 2.1.0 and not working..

@port19x

port19x commented May 5, 2022

Copy link
Copy Markdown
Collaborator

Wait wait.. we don't hv native package on termux yet.. I also read all those link u send but right now it's not in standard repos.. I checked it now and installed it.. but it's installing the standard mpv... Not the custom one we wrote in our documentation Also it's an older version.. like 2.1.0 and not working..

Which is why I currently have an open PR at the termux-packages repo...

@port19x
port19x merged commit ff40321 into master May 5, 2022
@port19x

port19x commented May 5, 2022

Copy link
Copy Markdown
Collaborator

I just want to see if termux native package is viable under ideal conditions

@port19x
port19x deleted the ani-sync-windows branch May 5, 2022 23:11
billmal071 pushed a commit to billmal071/ani-cli that referenced this pull request Jun 26, 2026
@justchokingaround chokerman @port19x
feat: ani-sync on windows (pystardust#700)
acfa262 
* feat: ani-sync on windows

* refactor: remove whitespace

* refactor: merge windows uname cases

* chore: -s demo in help menu

* docs: added matrix and revolt to README

* chore: remove unecessary space

* advise usage of native termux package

Co-authored-by: chokerman <ivan@chokerman.local>
Co-authored-by: port19 <port19@port19.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@port19x port19x port19x left review comments
@Derisis13 Derisis13 Derisis13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Long acces times

4 participants

@justchokingaround @port19x @CoolnsX @Derisis13