inconsistent parsing of addopts in toml

[nedbat]

Using 8.4.2, I had this in my pyproject.toml:

[tool.pytest.ini_options]
addopts = "-q -n auto --dist=loadgroup -p no:legacypath --strict-markers --no-flaky-report -rfEX --failed-first"

Two of the options there take values: -n auto and -p no:legacypath. To get it to work with 9.0.0, I needed:

[tool.pytest]
addopts = [
    "-q",
    "-n=auto",
    "--dist=loadgroup",
    "-p no:legacypath",
    "--no-flaky-report",
    "-rfEX",
    "--failed-first",
]

The -n option needs an equals sign. If I use -n auto, I get:

ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: argument -n/--numprocesses: invalid parse_numprocesses value: ' auto'

But -p needs a space. If I used "-p=no:legacypath", I got this error:

ImportError: Error importing plugin "=no:legacypath": No module named '=no:legacypath'

[bluetech]

I think the correct way to write it would be:

[tool.pytest]
addopts = [
    "-q",
    "-n", "auto",
    "--dist", "loadgroup",
    "-p", "no:legacypath",
    "--no-flaky-report",
    "-rfEX",
    "--failed-first",
]

Basically it's passed directly as an argument array to argparse, we don't perform any additional splitting on addopts in "native" TOML mode.

I am surprised that -n=auto works, generally short options don't accept = as far I know. I will need to check what the difference is compared to -p. But I recommend avoiding it since it seems inconsistent, and pass -n and auto as separate args, and similarly for -p.

[nedbat]

Your format works, and is consistent for all the settings, thanks.