Added an environment variable which helps to check if a code is running from within a pytest run, Fixes #9502 #12190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, this is set when pytest is running and unset just before pytest is stopped
nicoddemus
requested changes
Apr 6, 2024
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @dheerajck!
Please see my suggestions.
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Contributor
Author
|
also can I ask why was a ut failing before the latest commit but not right now |
nicoddemus
requested changes
Apr 7, 2024
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
See my suggestion to preserve the original PYTEST_VERSION, so pytester.runpytest() is more robust.
…t run by the calling process, we set it back after pytest run Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
for more information, see https://pre-commit.ci
Contributor
Author
|
Do we need any more changes |
Contributor
Author
adamchainz
reviewed
Apr 18, 2024
Member
adamchainz
left a comment
adamchainz
left a comment
There was a problem hiding this comment.
Thank you very much. This is a clean approach and may have other use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.