config: apply --override-ini eagerly
#13830
Merged
+53
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
commented
Oct 19, 2025
| inicfg.update(ini_overrides) | ||
|
|
||
| assert rootdir is not None | ||
| return rootdir, inipath, inicfg or {}, ignored_config_files |
There was a problem hiding this comment.
Unrelated cleanup, the or isn't needed.
nicoddemus
reviewed
Oct 20, 2025
nicoddemus
approved these changes
Oct 20, 2025
Currently ini overrides are handled lazily in `getini`, but I think it just complicates things and I don't see a reason to it lazily. Do it eagerly in `determine_setup` instead.
bluetech
force-pushed
the
simplify-override-ini
branch
from
44a7fc8 to
15c2e19
Compare
We don't have "trivial" but I added a "misc" one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ini overrides are handled lazily in
getini, but I think it just complicates things and I don't see a reason to do it lazily.Do it eagerly in
determine_setupinstead.