-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
📦 Pass desired release to PEP 517 tox env #13933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| The tox configuration has been adjusted to make sure the desired | ||
| version string can be passed into its :ref:`package_env` through | ||
webknjaz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| the ``SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST`` environment | ||
| variable as a part of the release process -- by :user:`webknjaz`. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 13933.contrib.rst | ||
webknjaz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,26 @@ envlist = | |
|
|
||
|
|
||
|
|
||
| [pkgenv] | ||
| # NOTE: This section tweaks how Tox manages the PEP 517 build | ||
| # NOTE: environment where it assembles wheels (editable and regular) | ||
| # NOTE: for further installing them into regular testenvs. | ||
| # | ||
| # NOTE: `[testenv:.pkg]` does not work due to a regression in tox v4.14.1 | ||
| # NOTE: so `[pkgenv]` is being used in place of it. | ||
| # Refs: | ||
| # * https://github.com/tox-dev/tox/pull/3237 | ||
| # * https://github.com/tox-dev/tox/issues/3238 | ||
| # * https://github.com/tox-dev/tox/issues/3292 | ||
| # * https://hynek.me/articles/turbo-charge-tox/ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm I learned through this article that we might not need
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bluetech not sure but I tend to use |
||
| # | ||
| # NOTE: The `SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST` environment | ||
| # NOTE: variable allows enforcing a pre-determined version for use in | ||
| # NOTE: the wheel being installed into usual testenvs. | ||
| pass_env = | ||
| SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST | ||
|
|
||
|
|
||
| [testenv] | ||
| description = | ||
| run the tests | ||
|
|
@@ -49,7 +69,6 @@ passenv = | |
| COVERAGE_* | ||
| PYTEST_ADDOPTS | ||
| TERM | ||
| SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST | ||
| CI | ||
| setenv = | ||
| _PYTEST_TOX_DEFAULT_POSARGS={env:_PYTEST_TOX_POSARGS_DOCTESTING:} {env:_PYTEST_TOX_POSARGS_LSOF:} {env:_PYTEST_TOX_POSARGS_XDIST:} {env:_PYTEST_FILES:} | ||
|
|
@@ -141,8 +160,6 @@ setenv = | |
| description = | ||
| regenerate documentation examples under `{basepython}` | ||
| changedir = doc/en | ||
| passenv = | ||
| SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST | ||
| deps = | ||
| PyYAML | ||
| regendoc>=0.8.1 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 https://pytest--13933.org.readthedocs.build/en/13933/changelog.html#packaging-updates-and-notes-for-downstreams