Skip to content

Conversation

@github-actions
Copy link
Contributor

Created by the prepare release pr workflow.

Once all builds pass and it has been approved by one or more maintainers, start the deploy workflow, using these parameters:

  • Use workflow from: release-9.0.1.
  • Release version: 9.0.1.

Or execute on the command line:

gh workflow run deploy.yml -r release-9.0.1 -f version=9.0.1

After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.

$ pytest --version
pytest 9.0.0
pytest 9.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nicoddemus nicoddemus marked this pull request as ready for review November 11, 2025 22:33
? - -
+ '4': 4,
}
FAILED test_verbosity_example.py::test_long_text_fail - AssertionError: assert 'hello world' in 'Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ips... sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like these changes should have gone into the 9.0.0 release... 🤔

@nicoddemus
Copy link
Member

nicoddemus commented Nov 11, 2025

pre-commit is failing with:

hook `pylint` has unsupported language `system`

I cannot reproduce this locally. Strange, language: system is something supported by pre-commit itself (pylint is actually a local hook and only executed manually).

I noticed it is building with an image released just today, might be related:

image ghcr.io/pre-commit-ci/runner-image:2025-11-11-0856608

Perhaps @asottile can chime in?

EDIT: I see this in the pre-commit changelog:

- Add `language: unsupported` / `language: unsupported_script` as aliases
  for `language: system` / `language: script` (which will eventually be
  deprecated).
    - #3577 PR by @asottile.

@nicoddemus
Copy link
Member

nicoddemus commented Nov 11, 2025

Pushed the fix for pre-commit in afce953. I will cherry-pick this back into main (EDIT: #13939).

@asottile
Copy link
Member

huh that's a weird one. I guess I used the stricter parser in pre-commit ci by mistake

you'll probably want to use minimum_pre_commit_version to force the upgrade if using the new language name. I'll fix ci separately oops

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 12, 2025
In pytest-dev#13939 we are using the new `language: unsupported` setting, which was introduced in pre-commit 4.4.0.

Configure minimum pre-commit version to ensure the installed pre-commit supports it (pytest-dev#13938 (comment)).
@nicoddemus
Copy link
Member

nicoddemus commented Nov 12, 2025

you'll probably want to use minimum_pre_commit_version to force the upgrade if using the new language name.

Thanks, done: #13941

@asottile
Copy link
Member

ok I've fixed pre-commit ci to not early approach the deprecation 😆 small oversight pre-commit-ci/runner-image#316

@nicoddemus
Copy link
Member

Waiting on a second approval before proceeding with the release. 👍

E assert [0, 0, 0, 0, 0, 0, ...] == [0, 0, 0, 0, 0, 0, ...]
E
E At index 100 diff: 1 != 2
E Use -v to get more diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems bad, any idea why it no longer truncates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: better to see this comment in the diff itself to understand...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems related to the changes in how we handle the CI environment variable... will investigate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this will fix it: #13950.

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.

Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.

See pytest-dev#13938 (comment).
nicoddemus added a commit that referenced this pull request Nov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.

Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.

See #13938 (comment).
patchback bot pushed a commit that referenced this pull request Nov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.

Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.

See #13938 (comment).

(cherry picked from commit 82e9b97)
nicoddemus added a commit that referenced this pull request Nov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.

Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.

See #13938 (comment).

(cherry picked from commit 82e9b97)

Co-authored-by: Bruno Oliveira <bruno@pytest.org>
@nicoddemus
Copy link
Member

Attempting this again after #13950.

@nicoddemus nicoddemus closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants