Skip to content

Fix #3539: reload module with assertion rewrite import hook #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2018
Merged

Fix #3539: reload module with assertion rewrite import hook #4022

merged 1 commit into from
Sep 23, 2018

Conversation

@iwanb
Copy link
Contributor

@iwanb iwanb commented Sep 23, 2018 •
edited by nicoddemus
Loading

The current reload hook did not reload code of already imported modules.
See https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module

Fix #3539

@coveralls
Copy link

coveralls commented Sep 23, 2018

Coverage Status

Coverage increased (+0.02%) to 93.811% when pulling c61ff31 on iwanb:fix_reload into ec57cbf on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks!

@RonnyPfannschmidt RonnyPfannschmidt merged commit eca3e78 into pytest-dev:master Sep 23, 2018
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Sep 23, 2018

fabulous 👍

@Zac-HD Zac-HD mentioned this pull request Oct 20, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iwanb @coveralls @RonnyPfannschmidt @nicoddemus