Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 13, 2018

  • use py27-pexpect,py27-trial,py27-numpy and py37-xdist in baseline,
    using pexpect there catches errors with pdb tests early, and
    py37-xdist is much faster than py37.
  • move py34 and py36 out of baseline.

- use py27-pexpect,py27-trial,py27-numpy and py37-xdist in baseline,
  using pexpect there catches errors with pdb tests early, and
  py37-xdist is much faster than py37.
- move py34 and py36 out of baseline.
- TOXENV: "py37-xdist"
- TOXENV: "py27-xdist"
- TOXENV: "py27"
- TOXENV: "py37"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that it's ok to remove py27 and py37 here then, but left it out for now.
It might be good to run everything with xdist on AppVeyor (but would need new tox factors).

@blueyed
Copy link
Contributor Author

blueyed commented Nov 13, 2018

Re AppVeyor (2nd commit): py27-xdist is slower than py27 there.. https://ci.appveyor.com/project/pytestbot/pytest/builds/20250577

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #4380 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4380      +/-   ##
=========================================
+ Coverage   95.88%   95.9%   +0.02%     
=========================================
  Files         111     111              
  Lines       24928   24928              
  Branches     2431    2431              
=========================================
+ Hits        23901   23908       +7     
+ Misses        726     723       -3     
+ Partials      301     297       -4
Flag Coverage Δ
#docs 29.66% <ø> (+0.07%) ⬆️
#doctesting 29.66% <ø> (+0.07%) ⬆️
#linting 29.66% <ø> (+0.07%) ⬆️
#linux 95.73% <ø> (+0.02%) ⬆️
#nobyte 92.33% <ø> (ø) ⬆️
#numpy 93.12% <ø> (ø) ⬆️
#pexpect 41.79% <ø> (ø) ⬆️
#py27 94.03% <ø> (+0.02%) ⬆️
#py34 92.15% <ø> (+0.06%) ⬆️
#py35 92.16% <ø> (+0.06%) ⬆️
#py36 92.18% <ø> (+0.06%) ⬆️
#py37 94.1% <ø> (+0.02%) ⬆️
#trial 93.12% <ø> (ø) ⬆️
#windows 94.1% <ø> (ø) ⬆️
#xdist 93.93% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/_pytest/capture.py 93.87% <0%> (+0.45%) ⬆️
src/_pytest/terminal.py 93.02% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243d898...3e05848. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Regarding xdist on AppVeyor, it seems to vary depending on the actual hardware that the job runs, in which case it will slowdown a bit (I've seen the same on Travis).

@blueyed blueyed merged commit 46c8363 into pytest-dev:master Nov 13, 2018
@blueyed blueyed deleted the improve-ci branch November 13, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants