Doc update - recommend use venv instead of virtualenv #4813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the Python docs: "Changed in version 3.5: The use of venv is now recommended for creating virtual environments." -https://docs.python.org/3/library/venv.html
update links for virtualenv -> venv
nicoddemus
reviewed
Feb 20, 2019
doc/en/goodpractices.rst
Outdated
| ------------------------------------------------- | ||
|
|
||
| For development, we recommend to use virtualenv_ environments and pip_ | ||
| For development, we recommend you use venv_ for virtual environments and pip_ |
There was a problem hiding this comment.
Thanks @Bjwebb!
Good suggestion, but because we still support Python 2.7 and 3.4, I believe we should mention both, perhaps like this:
we recommend you use venv[link] for virtual environments (or virtualenv[link] for Python 2.7 and 3.4) and pip ...
What do you think?
There was a problem hiding this comment.
Updated PR to mention virtualenv for Python 2.7.
Python 3.4 comes with venv, so I just mentioned 2.7 needing virtualenv. Source.
`venv` is already available in Python 3.4, my mistake
Codecov Report
@@ Coverage Diff @@
## master #4813 +/- ##
==========================================
- Coverage 95.77% 93.91% -1.86%
==========================================
Files 113 113
Lines 25652 25145 -507
Branches 2505 2495 -10
==========================================
- Hits 24567 23616 -951
- Misses 769 1186 +417
- Partials 316 343 +27
Continue to review full report at Codecov.
|
|
Merging as docs have passed already. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend use venv instead of virtualenv
From the Python docs:
"Changed in version 3.5: The use of venv is now recommended for creating virtual environments."
-https://docs.python.org/3/library/venv.html