Skip to content

Conversation

@ankostis
Copy link
Contributor

Fix #7514 by augmenting Note with behaviour when parametrized values are mutated
(changes are reflected in subsequent test-case calls).

Fix #7514 by augmenting Note with behaviour when parametrized values are mutated
(changes are reflected in subsequent test-case calls).
@ankostis
Copy link
Contributor Author

Oups, ..my apologies, i forgot i had dev access in pytest, and github-UI opened my new PR in the original repo.

Sgould i delete it (if am i allowed to) and do the proper thing from my fork?

@The-Compiler
Copy link
Member

Oups, ..my apologies, i forgot i had dev access in pytest, and github-UI opened my new PR in the original repo.

I'd say don't worry about it. We can always delete the branch after the PR is merged.

@ankostis ankostis force-pushed the doc-parameter-mutation branch from c8fce87 to b676882 Compare July 20, 2020 10:46
@ankostis
Copy link
Contributor Author

I'm seeing some failures in Windows...could it be that my last commit message contains the non-ASCII char §?

@The-Compiler
Copy link
Member

The-Compiler commented Jul 20, 2020

@ankostis That's not related to your change, most likely a change in the GitHub Actions environment. I opened #7518.

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankostis!

Since the Windows failure are unrelated, I am going to force-merge it.

@bluetech bluetech merged commit 07ed197 into master Jul 20, 2020
@bluetech bluetech deleted the doc-parameter-mutation branch July 20, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mutation in parameterized value is seen across repeated calls of the test-case

4 participants