Fix skip signature #8392
Fix skip signature #8392
Conversation
The `--strict` argument was removed in pytest-dev#2552, but the removal wasn't actually correct - see pytest-dev#1472.
| reason = "unconditional skip" | ||
| return Skip(reason) | ||
| try: | ||
| return Skip(*mark.args, **mark.kwargs) |
There was a problem hiding this comment.
Using the existing __init__ rather than hand-rolling argument parsing will also catch other issues, like giving too many arguments to the mark. All those were silently ignored before.
| """ | ||
| ) | ||
| result = pytester.runpytest("-rs") | ||
| result = pytester.runpytest("-rs", "--strict-markers") |
src/_pytest/skipping.py
Outdated
| try: | ||
| return Skip(*mark.args, **mark.kwargs) | ||
| except TypeError as e: | ||
| raise TypeError(str(e) + " - maybe you meant pytest.mark.skipif?") |
There was a problem hiding this comment.
I'm not doing "from e" here because it's not really relevant to the user where the exception comes from.
There was a problem hiding this comment.
would from None Make sense to completely suppress it?
There was a problem hiding this comment.
Seems reasonable - added!
Yeah it is a bit ambiguous, but IMHO the breaking change only happens because of misuse (according to the documentation), plus the misuse is hiding a problem, so I consider it a bugfix. 👍 |
The-Compiler
left a comment
The-Compiler
left a comment
There was a problem hiding this comment.
Thanks everyone for the quick reviews!
5 participants
Not sure if this should qualify as a bugfix, or if it should rather be a breaking change? Though affected tests were silently skipped before, which seems quite bad.