-
Notifications
You must be signed in to change notification settings - Fork 316
feat(create-pyth-package): added a create-pyth-package script to generate things with best practices baked-in #3185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cprussin
approved these changes
Nov 12, 2025
Collaborator
cprussin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor questions & thoughts but overall looks great!
packages/create-pyth-package/src/templates/cli/src/commands/index.ts
Outdated
Show resolved
Hide resolved
packages/create-pyth-package/src/templates/cli/src/create-command.ts
Outdated
Show resolved
Hide resolved
packages/create-pyth-package/src/templates/web-app/package.json
Outdated
Show resolved
Hide resolved
packages/create-pyth-package/src/templates/web-app/prettier.config.js
Outdated
Show resolved
Hide resolved
…he yargs helper function also fixed some of the generated contents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes possibility for footgunning by adding a generator that adheres to the JS best practices outlined in this Notion
Rationale
There are many different ways folks here have created and published JavaScript packages, some utilizing standardization and best practices, but many others lacking the consistency of best practices.
This generator removes the variability and allows everyone to be on the same package with package standards for libraries, CLIs and Web Apps.
How has this been tested?
See videos below:
Videos
Generating a CLI tool
generating-a-cli.mp4
Running the CLI after generation
running-cli.mp4
Generating a library
generating-a-library.mp4
Generating a next.js web app
generating-an-app.mp4