Manual verification with !verify sends the user the confirmation DM.#1328
Merged
Conversation
`ALTERNATE_VERIFIED_MESSAGE` now begins "You're now verified!" instead of "Thanks for accepting our rules!".
Previously, responses from the bot would say the name of the user rather than mentioning them.
swfarnsworth
requested review from
Akarys42,
Den4200,
ks129 and
mbaruh
as code owners
ghost
added
the
swfarnsworth
added
the
a: moderation
Contributor
Author
|
I didn't realize the native gate rollout was imminent when making this PR. I'll submit a new version that checks if the user is pending, and if not, assigns and subsequently removes the developer role. I'll probably also rename the function accordingly. |
…wfarnsworth/developer_command
Renamed method; if not `user.pending`, adds and immediately removes an arbitrary role (namely the Announcements role), which verifies the user.
…wfarnsworth/developer_command
Xithrius
reviewed
Dec 23, 2020
Contributor
Xithrius
left a comment
Xithrius
left a comment
There was a problem hiding this comment.
Besides this one line in the ALTERNATE_VERIFIED_MESSAGE docstring that may need to be changed, everything looks good to me.
…wfarnsworth/developer_command
ks129
reviewed
Dec 24, 2020
This was a logic error. This functionality is unfortunately difficult to test outside of production.
ks129
approved these changes
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, users wouldn't get the DM from the bot that one usually gets when they verify if a moderator verifies them manually. This PR solves this.
Per @Den4200's request, the response from the bot also mentions the user rather than stating their account name.