Add support for !infractions by <m|me|uid>#1926
Merged
Merged
Conversation
TizzySaurus
added
t: feature
TizzySaurus
requested review from
Akarys42,
Den4200,
jb3,
ks129 and
mbaruh
as code owners
TizzySaurus
force-pushed
the
infractions-by-command
branch
from
31b3d60 to
f315f4c
Compare
mbaruh
requested changes
Nov 2, 2021
TizzySaurus
force-pushed
the
infractions-by-command
branch
from
c904d21 to
d79b069
Compare
Contributor
Author
- Add `format_infraction_count` and migrate - Improve logic for `actor` being `"m"`/`"me"` - Rename `search_by_user` to `search_by_actor` - Better Ordering Logic (thanks @ChrisLovering) - Make embed title consistent with other search embeds
TizzySaurus
force-pushed
the
infractions-by-command
branch
from
d79b069 to
06d0c8f
Compare
jchristgit
requested changes
Nov 3, 2021
Contributor
Author
|
I'm still not able to reply to reviews for some reason but have fixed @jchristgit 👍 |
jchristgit
approved these changes
Nov 4, 2021
Contributor
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
Rock solid, thank you.
Bluenix2
reviewed
Nov 8, 2021
Contributor
Author
|
Still can't reply to reviews (GitHub seems to hate me) but you're perfectly right. Have just fixed @Bluenix2 👍 |
mbaruh
requested changes
Nov 9, 2021
Member
mbaruh
left a comment
mbaruh
left a comment
There was a problem hiding this comment.
Looks 99% good, just two small comments.
Embed for `!infractions by` no longer has the author in codeblock.
Merged
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1922.
Added support for
!infractions bysubcommand. See issue for more details on command usage & invocation.