Skip to content

Fix !infractions by me#1947

Merged
HassanAbouelela merged 1 commit into
mainfrom
infractions-by-command
Nov 10, 2021
Merged

Fix !infractions by me#1947
HassanAbouelela merged 1 commit into
mainfrom
infractions-by-command

Conversation

@TizzySaurus
Copy link
Copy Markdown
Contributor

Extension to #1926.

The literal converter is now before the Member converter so that "me"/"m" isn't attempted to be converted to a Member.

Also swaps from discord.Member to UnambiguousMember.

@HassanAbouelela HassanAbouelela enabled auto-merge (squash) November 10, 2021 20:53
@HassanAbouelela HassanAbouelela added a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority t: bug Something isn't working labels Nov 10, 2021
Comment thread bot/exts/moderation/infraction/management.py Outdated
@TizzySaurus TizzySaurus requested a review from mbaruh November 10, 2021 21:16
Comment thread bot/exts/moderation/infraction/management.py Outdated
- Change from `discord.Member` to `UnambiguousUser`
- Put the literal converter before the `UnambiguousUser` converter so that "me"/"m" isn't attempted to be converted to a Member.

`

Fix lint
@TizzySaurus TizzySaurus force-pushed the infractions-by-command branch from 2e0e0a1 to a1b554d Compare November 10, 2021 21:32
Copy link
Copy Markdown
Member

@mbaruh mbaruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@HassanAbouelela HassanAbouelela merged commit 9c0d91b into main Nov 10, 2021
@HassanAbouelela HassanAbouelela deleted the infractions-by-command branch November 10, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority t: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants