Added suppress for NotFound error#1976
Merged
Merged
Conversation
Hashed0719
requested review from
Akarys42,
Den4200,
jb3,
ks129 and
mbaruh
as code owners
jchristgit
requested changes
Nov 24, 2021
Contributor
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
Thank you for your PR!
I think we can leave out the suppress in one of the two spots, I left a comment there. Otherwise, this looks great.
Comment on lines
+286
to
+289
| if len(to_delete) == 100: | ||
| # Only up to 100 messages can be deleted in a bulk | ||
| await channel.delete_messages(to_delete) | ||
| with suppress(NotFound): | ||
| await channel.delete_messages(to_delete) |
Contributor
There was a problem hiding this comment.
I believe in this case we can leave out the suppress, as we know it will be a bulk delete per len(to_delete) == 100, which doesn't care that the messages are absent.
Contributor
Author
There was a problem hiding this comment.
I agree.
My bad I missed, it was specified there.
ichard26
added
a: moderation
ChrisLovering
approved these changes
Nov 24, 2021
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves BOT-1QH
Solves #1963
issue reference