Limit the length of the invalid rule indices message#1980
Merged
Conversation
bsoyka
added
t: bug
ChrisLovering
approved these changes
Nov 27, 2021
... is used everywhere else across the codebase where extwrap.shorten is used, so I'm making it match here.
Contributor
Author
|
Changed the placeholder since it's |
D0rs4n
approved these changes
Nov 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1975, which shows that extremely long invalid rule indices errors, as shown below, throw an error if the message is long enough.
This PR limits the length of the invalid indices string to 50 characters to avoid errors like the one shown in Sentry.