Skip to content

Small changes to invalid rule indices message shortening#1981

Merged
jchristgit merged 3 commits into
mainfrom
bsoyka/rules-shortening-space
Nov 29, 2021
Merged

Small changes to invalid rule indices message shortening#1981
jchristgit merged 3 commits into
mainfrom
bsoyka/rules-shortening-space

Conversation

@bsoyka
Copy link
Copy Markdown
Contributor

@bsoyka bsoyka commented Nov 27, 2021

This is a quick visual fix to add onto #1980. It adds a space before the ellipsis in the placeholder.

image

@bsoyka bsoyka added the a: frontend Related to output and formatting label Nov 27, 2021
Doing this similar to how the docs command works for shortening
@bsoyka bsoyka changed the title Add missing space in text shortening placeholder Small changes to invalid rule indices message shortening Nov 27, 2021
@Xithrius Xithrius added p: 3 - low Low Priority s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features labels Nov 28, 2021
@jchristgit
Copy link
Copy Markdown
Contributor

This also changes the length from 50 to 75. Was that intentional?

@bsoyka
Copy link
Copy Markdown
Contributor Author

bsoyka commented Nov 28, 2021

This also changes the length from 50 to 75. Was that intentional?

@jchristgit Yes, because similar to how this is done elsewhere in the bot's code, the :x: Invalid rule indices: string is now part of the shorten call, which adds about 25 characters.

@jchristgit jchristgit enabled auto-merge November 28, 2021 17:31
@jchristgit jchristgit merged commit 22af562 into main Nov 29, 2021
@jchristgit jchristgit deleted the bsoyka/rules-shortening-space branch November 29, 2021 11:00
@Xithrius Xithrius removed the s: needs review Author is waiting for someone to review and approve label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: frontend Related to output and formatting p: 3 - low Low Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants