Bump pydantic-settings from 2.1.0 to 2.2.0#2927
Conversation
6338087 to
3828f69
Compare
Bumps [pydantic-settings](https://github.com/pydantic/pydantic-settings) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/pydantic/pydantic-settings/releases) - [Commits](pydantic/pydantic-settings@v2.1.0...v2.2.0) --- updated-dependencies: - dependency-name: pydantic-settings dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
3828f69 to
64e0893
Compare
634c414 to
1c06ffe
Compare
|
I've updated the config tests to make sure we can rely on the unit test upon bumping pydantic PRs |
1c06ffe to
68c4219
Compare
|
A newer version of pydantic-settings exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
wookie184
left a comment
There was a problem hiding this comment.
I don't really understand the purpose of the added changes. What was wrong with the existing test? Why is the change in this PR? Why does whether it's running in CI need to be relevant to the test here?
The existing test dates back to when where we loaded the config from the yaml file, it's not relevant anymore sections = (
cls
for (name, cls) in inspect.getmembers(constants)
if hasattr(cls, "section") and isinstance(cls, type)
)This evaluates to nothing, so the test isn't doing anything.
I figured i'd contextualize testing pydantic settings along with this PR since it bumps that package, and I didn't want to test manually each time so I added it here. It doesn't really matter whether it's here or in a separate PR.
Because I wanted to test that pydantic loads variables correctly from the environment, not the env file. And I can't guarantee the value of an env variable on contribs machine if they ever run tests, which will cause a failure when such a variable doesn't exist :) |
Makes sense, thanks 👍
It's not ideal for a test to behave differently in CI versus locally. Can we use
I think in general keeping PRs as atomic as possible is best since it makes them easier to review, keeps discussion in the PR focussed on one thing, and prevents blocking one thing on another. It's fine to leave it here though. |
|
@dependabot recreate |
|
Superseded by #2934. |
|
@wookie184 I've closed this and Merged a new PR bump. |
Bumps pydantic-settings from 2.1.0 to 2.2.0.
Release notes
Sourced from pydantic-settings's releases.
Commits
965d1b4Prepare release 2.2.0 (#232)cde78d8Update requirements (#233)15b66dfFix dotenv source extra values parsing provided in dotenv file (#221)8b92f61feat: adding json, yaml and toml sources (#211)0a00678Improve docs (#225)40230abFix for JSON on optional nested types. (#217)a6f6fa4Ensure extra='forbid' is enforced in DotEnvSettingsSource when env_prefix is ...cc6dc25Add support for parsing environment "None" strings to None. (#206)9c26c1eFix typo in explode_env_vars() docstring (#207)2784a70Allow nested env var source to override nested init source. (#204)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)