Skip to content

Make DEFCON days subcommand enable DEFCON#405

Merged
scragly merged 4 commits into
masterfrom
defcon-fix-django
Sep 23, 2019
Merged

Make DEFCON days subcommand enable DEFCON#405
scragly merged 4 commits into
masterfrom
defcon-fix-django

Conversation

@sco1
Copy link
Copy Markdown
Contributor

@sco1 sco1 commented Sep 10, 2019

As currently written, the defcon days x command only updates the account age threshold and does not enable DEFCON on the bot (it does, however, enable it on the site). This PR rectifies this discrepancy & enables DEFCON on the bot if it's not already enabled.

This PR also refactors the in-channel & log message generation to cut down on the copy+paste.

This should be merged after #406

Closes: #394

@scragly scragly changed the base branch from django to master September 15, 2019 08:58
@sco1 sco1 marked this pull request as ready for review September 22, 2019 19:17
Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% reasonable PR.

@scragly scragly merged commit aeb3bfa into master Sep 23, 2019
@scragly scragly deleted the defcon-fix-django branch September 23, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFCON days subcommand should enable DEFCON

5 participants