Update linting#406
Conversation
* Add flake8-annotations * Add flake8-docstrings
d691b9a to
2ac0c6d
Compare
There was a problem hiding this comment.
Partial review, my time's up for now, but I think leaving a partial review speeds up the process with such a large number of changes. I've gone through the files manually and checked the function signatures myself.
Also, why doesn't this cause a linting error? It seems to be missing a return type annotation:
Edit: We've ignored TYP206/classmethod return value annotations.
Lines 303 to 306 in 138567f
Fix decorator return hints Co-Authored-By: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
Co-Authored-By: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
SebastiaanZ
left a comment
There was a problem hiding this comment.
I've looked through all the files now, I think.
This inner-function in bot.cogs.utils does not have a return value annotation, it should be Tuple[str, str]
Co-Authored-By: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
|
Apparently, I messed a few things during my review; apologies. |
Co-Authored-By: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
I'm going to look over the code once again to make sure I haven't missed more of those.
Co-Authored-By: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
Co-Authored-By: Leon Sandøy <leon.haland@gmail.com>
|
I'm currently reviewing this by the way |
Co-Authored-By: Mark <kozlovmark@gmail.com>
Co-Authored-By: Mark <kozlovmark@gmail.com>
62bf84f to
452618c
Compare
Per #384, this PR updates the django branch's linting dependencies & relints the codebase.
To potentially help ease review I've split the diffs into discrete chunks, but can squash them into a single commit if preferable.
Closes: #384