Skip to content

Various fixes related to thread support#13

Merged
jchristgit merged 4 commits into
mainfrom
threadfixes
Feb 18, 2022
Merged

Various fixes related to thread support#13
jchristgit merged 4 commits into
mainfrom
threadfixes

Conversation

@ChrisLovering
Copy link
Copy Markdown
Member

This fixes a few bugs around threads namely:

  1. Ignore threads within forum channels. These aren't supported by d.py so we want to avoid tracebacks.
  2. Listen for thread create and unarchive events explicitly
    • Discord.py only firsts thread_update events for threads in the cache, this isn't the case for threads being created, and threads being unarchived, so there events were previously being missed from the channel sync.
  3. Only sync archive status on startup
    • Since we now sync archive flags during bot runtime, there is no need to sync this every time we sync threads.

Since we can update threads during bot runtime, there is no need to sync archive status every time, just do this on startup.
Discord.py doesn't support forum channels, so ignore them to avoid tracebacks.
@ChrisLovering ChrisLovering requested a review from jb3 as a code owner February 13, 2022 18:55
Copy link
Copy Markdown
Contributor

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust.

@jchristgit jchristgit merged commit e5b81f2 into main Feb 18, 2022
@jchristgit jchristgit deleted the threadfixes branch February 18, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants