Skip to content

Allow changing the config file location with CONFIG_LOCATION#56

Merged
ChrisLovering merged 1 commit into
python-discord:mainfrom
Akarys42:patch-1
Jun 20, 2023
Merged

Allow changing the config file location with CONFIG_LOCATION#56
ChrisLovering merged 1 commit into
python-discord:mainfrom
Akarys42:patch-1

Conversation

@Akarys42
Copy link
Copy Markdown
Contributor

Currently, it is mandatory for you to put the config file in the same folder as the code. This raises issues in environments such as Kubernetes. This commit allows the user to use CONFIG_LOCATION to change the location of that file, while keeping the current behavior as default.

Currently, it is mandatory for you to put the config file in the same folder as the code. This raises issues in environments such as Kubernetes. This commit allows the user to use `CONFIG_LOCATION` to change the location of that file, while keeping the current behavior as default.
@Akarys42 Akarys42 requested a review from jb3 as a code owner June 20, 2023 00:28
Copy link
Copy Markdown

@shenanigansd shenanigansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisLovering
Copy link
Copy Markdown
Member

This raises issues in environments such as Kubernetes.

I'd be interested to know what these issued are, so I've asked in Python Discord

@ChrisLovering ChrisLovering merged commit 1e589e6 into python-discord:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants