Skip to content

Add support for certain unicode characters in ot names #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkKoz merged 2 commits into from
Sep 22, 2019
Merged

Add support for certain unicode characters in ot names #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07e483
Add test for certain unicode characters in ot names
MarkKoz Aug 9, 2019
7b3af30
Remove redundant off-topic names list test
MarkKoz Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pydis_site/apps/api/tests/test_off_topic_channel_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,20 @@ def setUp(self):
super().setUp()

url = reverse('bot:offtopicchannelname-list', host='api')
self.name = "lemonade-shop"
self.name = "abcdefghijklmnopqrstuvwxyz-0123456789"
response = self.client.post(f'{url}?name={self.name}')
self.assertEqual(response.status_code, 201)

def test_name_in_full_list(self):
def test_returns_201_for_unicode_chars(self):
url = reverse('bot:offtopicchannelname-list', host='api')
response = self.client.get(url)
names = (
'𝖠𝖡𝖢𝖣𝖤𝖥𝖦𝖧𝖨𝖩𝖪𝖫𝖬𝖭𝖮𝖯𝖰𝖱𝖲𝖳𝖴𝖵𝖶𝖷𝖸𝖹',
'ǃ？’',
)

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), [self.name])
for name in names:
response = self.client.post(f'{url}?name={name}')
self.assertEqual(response.status_code, 201)

def test_returns_400_for_missing_name_param(self):
url = reverse('bot:offtopicchannelname-list', host='api')
Expand All @@ -111,8 +115,8 @@ def test_returns_400_for_bad_name_param(self):
url = reverse('bot:offtopicchannelname-list', host='api')
invalid_names = (
'space between words',
'UPPERCASE',
'$$$$$$$$'
'ABCDEFGHIJKLMNOPQRSTUVWXYZ',
'!?\'@#$%^&*()',
)

for name in invalid_names:
Expand Down