Refine Dockerfiles

[scragly]

I've done some refinement for the Dockerfiles. This has resulted in the following improvements:

• Build time is reduced from 1:08 to 0:50 when tested on my machine.
• Image size is reduced from 549.2 MB to 466.2MB
• Image size is further reduced to 440.2MB thanks to @MarkKoz's suggestion of disabling Pip cache.

Change Details

• Dockerfile.local has been changed to local.Dockerfile for better filetype detection.

• Changed from interactive adduser command that resulted in logged warnings to the non-interactive useradd command.

  • --system makes it a homeless non-login user.
  • --shell has been set to avoid possible security issues.

• uwsgi is now installed from the system package repository, as it is already built and actively updated, using the exact same version we did.

  • Since it's already built, previous build packages aren't installed.
  • Since build packages aren't installed, purging is removed (but as a note, this didn't reduce the container size anyway).

• install_packages is used instead of apt-get as it does cleanup, handles any prompts and doesn't install recommends automatically.

• COPY for Pipfiles and project files are now done at the same time.

• RUN commands have been tidied to use shorter references as the entrypoints are confirmed to be for the same locations.

• pipenv install has been moved to same RUN as setuptools

[MarkKoz]

Looks good. None of the Python dependencies need to be built with GCC, right?

[scragly]

Correct, it was only uwsgi. I was sure to actually run the resulting containers to ensure things still worked just in case I was mistaken beforehand.

[MarkKoz]

I think doing ENV PIP_NO_CACHE_DIR=false would be helpful since that'd also affect the dependencies pipenv installs, right? Could throw in a couple more to perhaps make logs nicer too:

ENV PIP_NO_CACHE_DIR=false \
    PIPENV_HIDE_EMOJIS=1 \
    PIPENV_NOSPIN=1

[scragly]

@MarkKoz Added the env vars suggested. It hasn't impacted size or build time, and confirmed it doesn't have any issues building and running the container with them.

Edit: I looked at wrong image details for size. It dropped to 440.2MB 🎉

[MarkKoz]

It's 440 MB if the cache is disabled, 466 MB if it is enabled. Are you sure you built the right Dockerfile when testing that? I noticed you only set those environment variables for local.Dockerfile

[scragly]

Yep, built the correct one, but just didn't look at the right image when checking the size. You're right, it's decreased again, which is great news.

I'll add them to the other container also.

[jchristgit]

rock solid

[jchristgit]

Thanks!