Django Allauth (#201)#274
Conversation
Turns out, setting this *does* move the model to a different category under the admin - but it also reparents it to the referenced app, so the migrations are created under that app instead. Nasty.
# Conflicts: # Pipfile # Pipfile.lock
|
Super happy to say that this PR is now ready for review! Here are some screenshots and videos that showcase the changes I've made. Login link in dropdown New Bulma colours, shown here as notification styles Django admin, showing a role mapping Django admin, showing my Discord account, sans email |
Co-Authored-By: Johannes Christ <jc@jchri.st>
jchristgit
left a comment
There was a problem hiding this comment.
This looks pretty solid so I will have to resort to notpicking :(
The role mapping model is just about the cleanest way I have seen to accomplish this. I think in my last implementation of this I just hardcoded that, but a nice admin frontend for it is pretty brilliant.
That said, if the role mappings update, shouldn't the signal handler fire?
|
Good catch on the missing signals. I'm leaving a short TODO list in this comment so I don't forget:
|
This also enforces unique values for both attributes on the RoleMapping model. Supporting configurations where this isn't the case would introduce quite a lot of added complexity.
|
Alright, I think that's all of your review addressed, @jchristgit! |
lemonsaurus
left a comment
There was a problem hiding this comment.
Very high quality PR, but I do have a few requests before I can approve.




This pull request implements Django Allauth as described in #201.
Fixes #201.
This is a fairly big PR which, I think, may have had a little scope creep. Here's what it changes:
django-allauthdependencydjango-allauthI would super love some reviews for this, particularly when it comes to the tests I wrote for the signal handlers, and the signal handling itself.
I'm not super happy with the signal handlers test - it's more setup than test! If anyone has any ideas on how to clean that up, I'd appreciate it.
Old TODO:
Profile page with GH connect/disconnect and account deleteCreate templates for the Allauth-provided account pagesEnsure login page explains the data we're collecting and collects explicit consent