Skip to content

Add favicons; workaround for gitattributes#279

Merged
lemonsaurus merged 1 commit into
masterfrom
favicons
Oct 11, 2019
Merged

Add favicons; workaround for gitattributes#279
lemonsaurus merged 1 commit into
masterfrom
favicons

Conversation

@ByteCommander
Copy link
Copy Markdown
Contributor

No description provided.

@jchristgit
Copy link
Copy Markdown
Contributor

Most of these have colours but the Safari one is just.. weird. is that intentional, or is that some Apple thing?

Kitty can't open it at all:

image

In Safari it's black and white

image

@lemonsaurus
Copy link
Copy Markdown
Contributor

I think it's some kind of Apple thing, since these were generated by a website that I've used for a bunch of sites with no issue. it probably works.

@ByteCommander
Copy link
Copy Markdown
Contributor Author

ByteCommander commented Oct 11, 2019

@jchristgit This Safari Pinned Tab icon must be a monochrome and transparent SVG, according to https://realfavicongenerator.net/. It offers several ways to convert the uploaded picture to a fitting format, including to upload a separate transparent PNG and convert it to a solid "shadow", which is what I did.
Probably that caused these small dot artifacts around the shape where we'd have a drop shadow in the original. Maybe there could have been a better approach by preparing a different icon from scratch or from the original SVG, but it seemed good enough this way, especially as it's going to be displayed only as small tab icon.
Btw not sure what kitty is, but eog opens it without any complaints.

@lemonsaurus lemonsaurus merged commit 9c43ef1 into master Oct 11, 2019
@lemonsaurus lemonsaurus deleted the favicons branch October 11, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants