Skip to content

Remove breadcrumb truncation#294

Merged
SebastiaanZ merged 2 commits into
python-discord:masterfrom
bsoyka:patch-1
Oct 25, 2019
Merged

Remove breadcrumb truncation#294
SebastiaanZ merged 2 commits into
python-discord:masterfrom
bsoyka:patch-1

Conversation

@bsoyka
Copy link
Copy Markdown
Contributor

@bsoyka bsoyka commented Oct 20, 2019

As per discussion in #meta in regards to the Code of Conduct page.

As per discussion in #meta
@gdude2002
Copy link
Copy Markdown
Contributor

This looks good to me, I'm about 90% sure this'll work, but it needs to be tested. If you're able to test it yourself, would you mind dropping a screenshot? Otherwise, I'll try to test when I have time.

@bsoyka
Copy link
Copy Markdown
Contributor Author

bsoyka commented Oct 20, 2019

@gdude2002 Tried to test it, but I can't get Docker to work right on my machine. Sorry! 😬

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the approach looks sound but we do need it tested before we can merge this.

I also ask myself how this will affect pages with unreasonably long names. Will it take up the entire page or do weird stuff like give us horizontal scrollbars?

I also wonder whether a better solution might've been smarter truncation instead of no truncation at all. For example, are breadcrumbs really worth having if there's only one level? Would the truncation perhaps look better if it didn't cut off in the middle of a word?

But anyway, this is probably an improvement for now at any rate.

@gdude2002
Copy link
Copy Markdown
Contributor

@bsoyka DM'd me last night to say they were having trouble setting up Docker and the site, so I'm testing it now.

It might be worth noting that the wiki is also forcibly limiting the slug for wiki pages to 50 chars - although that's not the entire url, it's just the slug for that specific article.

Here's how it looks.

image

@SebastiaanZ SebastiaanZ merged commit ef32c8c into python-discord:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants