API for tags#34
Merged
Merged
Conversation
Committing so I can go home >:|
Pull Request Test Coverage Report for Build 392
💛 - Coveralls |
gdude2002
reviewed
Mar 3, 2018
| elif error_code is ErrorCodes.incorrect_parameters: | ||
| data["error_message"] = "Incorrect parameters provided" | ||
| http_code = 400 | ||
| elif error_code is ErrorCodes.database_error: |
Contributor
There was a problem hiding this comment.
I'm not gonna fail your PR for this block because we need to rethink this entire system - but this is inconsistent.
Contributor
Author
There was a problem hiding this comment.
I think we should remove all that stuff, after the discussion we already had. But it's not really something we should do on this PR maybe. I can remove the additions I made into the system, though.
gdude2002
reviewed
Mar 3, 2018
| self.log = logging.getLogger() | ||
| self.app.secret_key = os.environ.get("WEBPAGE_SECRET_KEY", "super_secret") | ||
| self.app.config["SERVER_NAME"] = os.environ.get("SERVER_NAME", "pythondiscord.com:8080") | ||
| self.app.config["SERVER_NAME"] = os.environ.get("SERVER_NAME", "pythondiscord.local:8080") |
Contributor
There was a problem hiding this comment.
You guys really hate actually setting your env vars, don't you? :P
gdude2002
suggested changes
Mar 3, 2018
| from pysite.mixins import DBMixin | ||
|
|
||
|
|
||
| class TagsView(APIView, DBMixin): |
Contributor
There was a problem hiding this comment.
Should the methods in this class be validated? We have a decorator for that.
…ld probably rethink that whole custom error handling system anyway.
… into api_tag_improvements
…validating manually. Tested with bot staging.
gdude2002
approved these changes
Mar 5, 2018
jerbob
approved these changes
Mar 6, 2018
jerbob
approved these changes
Mar 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.