Skip to content

Add pagination and bulk update support for User(discord user) serializer. #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkKoz merged 42 commits into from
Oct 8, 2020
Merged

Add pagination and bulk update support for User(discord user) serializer. #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
4644084
add pagination for GET request on /bot/users endpoint
RohanJnr Aug 26, 2020
8e636a5
add support for bulk updates on user model
RohanJnr Aug 26, 2020
792af71
Add reference links in UserListSerializer methods
RohanJnr Aug 26, 2020
303cb19
Except AttributeError when self.instance is None and while fetching U…
RohanJnr Aug 26, 2020
567f7f0
Add code to replace restframework_bulk package for bulk create and si…
RohanJnr Aug 28, 2020
2aa12e7
Add tests for bulk patch for User Model and additional test for bulk …
RohanJnr Aug 28, 2020
bfe32de
Uninstall djangorestframework-bulk dependency
RohanJnr Aug 28, 2020
b3d4888
re-lcok pipfile
RohanJnr Aug 28, 2020
982ef75
remove redundant if clause in update() method in UserListSeriazlier.
RohanJnr Aug 28, 2020
c2fd139
Merge branch 'master' into user_endpoint
RohanJnr Sep 9, 2020
48fcd02
optimize bulk update endpoint by using Model.objects.bulk_update() me…
RohanJnr Sep 21, 2020
68728d2
Merge branch 'master' into user_endpoint
RohanJnr Sep 28, 2020
2e454f4
Merge branch 'master' into user_endpoint
RohanJnr Oct 4, 2020
5dda824
Merge remote-tracking branch 'upstream/master' into user_endpoint
RohanJnr Oct 4, 2020
e7a61d0
raise validation error for user not found in UserListSerializer
RohanJnr Oct 5, 2020
a956034
return next and previous page numbers in paginator instead of links
RohanJnr Oct 5, 2020
69342e8
Change test case to use updated code
RohanJnr Oct 5, 2020
3fe6ad3
Merge branch 'user_endpoint' of https://github.com/RohanJnr/site into…
RohanJnr Oct 5, 2020
3eee5e7
Update docstring of UserViewSet and correct function annotation on Us…
RohanJnr Oct 6, 2020
6b28ac6
overhaul create method to ignore conflicts and raise error when dupli…
RohanJnr Oct 6, 2020
3c63323
refactor tests to use updated changes and add tests for UserListPagin…
RohanJnr Oct 6, 2020
7b2275d
use more efficient code
RohanJnr Oct 7, 2020
5d3d305
Document changes made to UserListSerializer in UserViewSet
RohanJnr Oct 7, 2020
6201c91
add check for insufficient data in update method of UserListSerializer
RohanJnr Oct 7, 2020
a3bd656
add test case for insufficient data while bulk updating users.
RohanJnr Oct 7, 2020
5388034
update documentation
RohanJnr Oct 7, 2020
995c62b
catch IntegrityError and raise ValidationError during user creation.
RohanJnr Oct 8, 2020
6969333
fix bug: bulk_patch returns duplicate objects in the response
RohanJnr Oct 8, 2020
a907404
add test case: test_returns_400_for_existing_user
RohanJnr Oct 8, 2020
cb32322
raise ValidationError if users have same ID in request data during bu…
RohanJnr Oct 8, 2020
446db59
add testcase: test_returns_400_for_duplicate_request_users
RohanJnr Oct 8, 2020
ffab239
update documentation
RohanJnr Oct 8, 2020
fe851bd
use NON_FIELD_ERRORS_KEY for non-field-specific ValidationError response
RohanJnr Oct 8, 2020
cd72f72
normalize API error responses.
RohanJnr Oct 8, 2020
e741397
correct indentation
RohanJnr Oct 8, 2020
bdc69a7
fix bug with bulk create: response includes objects for users which w…
RohanJnr Oct 8, 2020
ec8a5fc
Merge branch 'master' into user_endpoint
RohanJnr Oct 8, 2020
570f0cf
return empty list as response for bulk creation of users
RohanJnr Oct 8, 2020
e405b60
supress warning: UnorderedObjectListWarning: Pagination may yield inc…
RohanJnr Oct 8, 2020
a57035b
Convert error message value from list to string
RohanJnr Oct 8, 2020
4e43549
Convert ValidationError response value to list from string
RohanJnr Oct 8, 2020
1bef883
Move Validation checks to serializer from viewset
RohanJnr Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ django-environ = "~=0.4.5"
django-filter = "~=2.1.0"
django-hosts = "~=4.0"
djangorestframework = "~=3.11.0"
djangorestframework-bulk = "~=0.2.1"
psycopg2-binary = "~=2.8"
django-simple-bulma = "~=1.2"
whitenoise = "~=5.0"
Expand Down
Loading