Skip to content

100k milestone timeline page#381

Merged
lemonsaurus merged 35 commits into
masterfrom
feat/timeline
Oct 17, 2020
Merged

100k milestone timeline page#381
lemonsaurus merged 35 commits into
masterfrom
feat/timeline

Conversation

@fiskenslakt
Copy link
Copy Markdown
Contributor

@fiskenslakt fiskenslakt commented Sep 3, 2020

Abstract

Our 100k milestone is coming up fast, and to celebrate we are creating a timeline of significant events in PyDis history.

This is an extremely rough draft as of writing, just wanted to get something out there.


CSS in the navbar is currently a little wonky, I think the stylesheet for the timeline is overwriting some stuff. Also I've yet to implement the movement when scrolling from the js.

timeline

@fiskenslakt fiskenslakt added status: WIP Work In Progress priority: 0 - critical Needs to be addressed ASAP area: frontend Related to site content and user interaction language: python Involves Python code language: javascript Involves Javascript code type: feature New feature or request labels Sep 3, 2020
@Akarys42
Copy link
Copy Markdown
Contributor

I’d just like to mention that I put together a little document some time ago of another PyDis timeline, maybe that could help you to complete this one.

@lemonsaurus
Copy link
Copy Markdown
Contributor

I’d just like to mention that I put together a little document some time ago of another PyDis timeline, maybe that could help you to complete this one.

This timeline is based on your document, but we've boiled it down to what we think is most important.

@ks129
Copy link
Copy Markdown
Contributor

ks129 commented Oct 3, 2020

I think this timeline shouldn't plain HTML, but YAML (entries) + Markdown (information) instead and this should dynamically load timeline items.

@Akarys42
Copy link
Copy Markdown
Contributor

Akarys42 commented Oct 3, 2020

This timeline is based on your document, but we've boiled it down to what we think is most important.

Alrighty, fisk wasn't sure if it was.

I think this timeline shouldn't plain HTML, but YAML (entries) + Markdown (information) instead and this should dynamically load timeline items.

Seeing how close the 100k are, we might as well go for the faster solution, and maybe refractor later.

@lemonsaurus lemonsaurus assigned fiskenslakt and jb3 and unassigned lemonsaurus Oct 4, 2020
@jb3
Copy link
Copy Markdown
Member

jb3 commented Oct 10, 2020

I've made a few fixes:

  • Fixed the CSS so it no longer overrides our own CSS
  • Removed the read more buttons, I think these events are summed up enough in a sentence or two.
  • Prettified the CSS and HTML so it is easier to work on
  • Enabled the JS since the load animations work on my MacBook, let me know if you experience otherwise (I don't think it won't work on phones, which is fine)

image

Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Comment thread pydis_site/templates/home/timeline.html Outdated
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
@jb3 jb3 marked this pull request as ready for review October 12, 2020 00:50
@jb3 jb3 requested a review from a team as a code owner October 12, 2020 00:50
@jb3 jb3 requested a review from kosayoda October 12, 2020 00:50
@ghost ghost added the needs 2 approvals label Oct 12, 2020
@jb3
Copy link
Copy Markdown
Member

jb3 commented Oct 12, 2020

Now with categories and colours!

Screenshot 2020-10-12 at 01 53 47

@lemonsaurus
Copy link
Copy Markdown
Contributor

Icons are too small. Also, the PyDis logo needs to be visually centered, so it needs a margin-left of around 2px. Can we have them more like this?

image

We also will need to change the date for the final timeline item, which now says "?? September"

@lemonsaurus
Copy link
Copy Markdown
Contributor

One more thought - are we adding the timeline somewhere so that it is possible to browse to it without the URL?

@jb3
Copy link
Copy Markdown
Member

jb3 commented Oct 12, 2020

Icons changed @lemonsaurus.

As of now, we aren't linking to it from anywhere. Maybe we should add a notice to the frontpage or something?

@jb3
Copy link
Copy Markdown
Member

jb3 commented Oct 12, 2020

Something like this

Screenshot 2020-10-12 at 09 57 31

Copy link
Copy Markdown
Contributor

@scragly scragly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to see a frontpage direct link that can direct to it in a lovely graphic manner.

On finishing my review, I notice you've mentioned something about this here, however I'm not a super fan of the plain-ness and the temporary feeling it gives off.

Comment thread pydis_site/static/css/home/timeline.css Outdated
@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Oct 12, 2020
Co-authored-by: scragly <29337040+scragly@users.noreply.github.com>
@ghost ghost added needs 2 approvals and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Oct 12, 2020
Copy link
Copy Markdown
Contributor

@kwzrd kwzrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the whole frontpage banner be a clickable link? I think that would be nice. It could grow a little bit on hover or change colour. Currently it looks like only the underlined here links. I agree that it comes with a sense of temporariness ~ are we planning to have this banner up permanently, or is it just to promote the 100k event?

@lemonsaurus
Copy link
Copy Markdown
Contributor

lemonsaurus commented Oct 12, 2020

I don't really want to remove the Welcome to Python Discord video from our front page, I think it's a valuable component and I almost want it to be there permanently. But this does mean we lose out on valuable real estate for advertising ongoing events and making big announcements. A bit of a conundrum.

That said, I do think having some sort of temporary notice for 100K would be great. I also think we need to put the timeline somewhere else so that it has a more permanent home - not sure precisely where this would be. I suppose our only real options are on the dropdown or in the resources. Both are a bit weird to me.

@lemonsaurus
Copy link
Copy Markdown
Contributor

Let's handle the frontpage stuff in a different PR. I think maybe this is ready to merge now?

@lemonsaurus lemonsaurus dismissed scragly’s stale review October 17, 2020 07:53

It's unreasonable!

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: frontend Related to site content and user interaction language: javascript Involves Javascript code language: python Involves Python code priority: 0 - critical Needs to be addressed ASAP status: WIP Work In Progress type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants