Skip to content

Logging cleanup#403

Merged
scragly merged 10 commits into
python-discord:masterfrom
ks129:logging-cleanup
Oct 6, 2020
Merged

Logging cleanup#403
scragly merged 10 commits into
python-discord:masterfrom
ks129:logging-cleanup

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Oct 3, 2020

Remove all logging-related things from site, because PyDis use now Sentry. Removed URL, viewset, model, tests. Also removed site internal logging into DB. Closes #347 .

@ks129 ks129 requested a review from a team as a code owner October 3, 2020 07:27
@ks129 ks129 requested review from GhostofGoes and aeros October 3, 2020 07:27
@ghost ghost added the needs 2 approvals label Oct 3, 2020
@lemonsaurus lemonsaurus requested a review from scragly October 5, 2020 17:22
@lemonsaurus
Copy link
Copy Markdown
Contributor

@scragly I think you're the only one familiar with this stuff. Can you review this? If you approve, just merge it.

@scragly
Copy link
Copy Markdown
Contributor

scragly commented Oct 6, 2020

No problem. It looks absolutely fine, but I'll do a quick deploy to ensure it runs without errors too.

@scragly
Copy link
Copy Markdown
Contributor

scragly commented Oct 6, 2020

Looks great, runs great. Thanks!

@scragly scragly merged commit 2137f6b into python-discord:master Oct 6, 2020
@ks129 ks129 deleted the logging-cleanup branch October 7, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove custom logging handler and log storage

3 participants