Skip to content

Dewikification: Remove django-wiki from the stack#405

Merged
lemonsaurus merged 8 commits into
dewikificationfrom
remove_django_wiki
Oct 4, 2020
Merged

Dewikification: Remove django-wiki from the stack#405
lemonsaurus merged 8 commits into
dewikificationfrom
remove_django_wiki

Conversation

@lemonsaurus
Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus commented Oct 4, 2020

This PR simply annihilates django-wiki and everything related to it.

  • All 263 tests are still passing
  • Smoke tested OK, website still seems to work fine.

This does not remove all the related tables from the database in production. A seperate issue exists to do this, see https://github.com/python-discord/admin-tasks/issues/37

@lemonsaurus lemonsaurus requested a review from a team as a code owner October 4, 2020 16:06
@ghost ghost added the needs 2 approvals label Oct 4, 2020
Copy link
Copy Markdown
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have references to django-nyt here

'django_nyt.apps.DjangoNytConfig',

and there

path('notifications/', include('django_nyt.urls')),

which cause the app to not start. Other than that, it looks good.

@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Oct 4, 2020
@ghost ghost added needs 2 approvals and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Oct 4, 2020
@lemonsaurus lemonsaurus merged commit f3c2c21 into dewikification Oct 4, 2020
@lemonsaurus lemonsaurus deleted the remove_django_wiki branch October 4, 2020 17:44
@lemonsaurus lemonsaurus linked an issue Oct 4, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dewikification: Remove django-wiki from the site

2 participants