Implement voice bans to API#411
Merged
Merged
Conversation
jb3
requested changes
Oct 10, 2020
Member
jb3
left a comment
jb3
left a comment
There was a problem hiding this comment.
Looking good ks!
This work fine locally, I've inserted a record and queried the endpoint, it returns the expected result.
I've added a slight comment because I think the error handling section in the viewset is handling for an impossible case.
| Infraction.objects.get(user__id=user.id, active=True, type="voice_ban") | ||
| except ObjectDoesNotExist: | ||
| voice_banned = False | ||
| except MultipleObjectsReturned: |
Member
There was a problem hiding this comment.
Will there ever be multiple active voice bans for a user?
These cannot be in the DB due to the one active infraction type per user constraint.
ERROR: duplicate key value violates unique constraint "unique_active_infraction_per_type_per_user"
ghost
added
s: waiting for author
scragly
suggested changes
Oct 10, 2020
Co-authored-by: Joe Banks <joseph@josephbanks.me>
ghost
added
needs 2 approvals
and removed
s: waiting for author
scragly
approved these changes
Oct 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
voice_baninfraction type.