Dewikification - Migrate event pages from wiki to HTML#427
Merged
Conversation
Contributor
|
@ks129 I'm not familiar with the new system you have in place, but I'd like to review this since I was requested and this has been sitting for almost a month. I suspect most of the HTML is copy-pasted from existing wiki pages. Can you fill me in on what I need to look out for in the code, if anything? Would running the site locally and going through each page in my browser be a sufficient test? |
MarkKoz
reviewed
Jan 5, 2021
Contributor
MarkKoz
left a comment
There was a problem hiding this comment.
I can't figure out how to get the the code jam or game jam pages. I've only managed to navigate to http://localhost:8000/events/ and the links in the event calendar are all broken.
MarkKoz
requested changes
Mar 18, 2021
Prevents page contents of events pages from being narrower when there is no sidebar to fill the space.
This makes it consistent with the django-wiki version of the code blocks, which looks neater.
MarkKoz
approved these changes
Mar 22, 2021
Contributor
MarkKoz
left a comment
There was a problem hiding this comment.
Everything looks to be in order now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #386
Migrated all current event pages to dewikified event pages system.