Skip to content

Dewikification - Migrate event pages from wiki to HTML#427

Merged
kosayoda merged 29 commits into
dewikificationfrom
ks123/dewikification/event-pages
Mar 23, 2021
Merged

Dewikification - Migrate event pages from wiki to HTML#427
kosayoda merged 29 commits into
dewikificationfrom
ks123/dewikification/event-pages

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Nov 28, 2020

Closes #386

Migrated all current event pages to dewikified event pages system.

@ks129 ks129 requested a review from jerbob November 28, 2020 13:41
@ks129 ks129 requested a review from a team as a code owner November 28, 2020 13:41
@ks129 ks129 requested a review from MarkKoz November 28, 2020 13:41
@ghost ghost added the needs 1 approval label Nov 28, 2020
@MarkKoz
Copy link
Copy Markdown
Contributor

MarkKoz commented Dec 25, 2020

@ks129 I'm not familiar with the new system you have in place, but I'd like to review this since I was requested and this has been sitting for almost a month. I suspect most of the HTML is copy-pasted from existing wiki pages. Can you fill me in on what I need to look out for in the code, if anything? Would running the site locally and going through each page in my browser be a sufficient test?

Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out how to get the the code jam or game jam pages. I've only managed to navigate to http://localhost:8000/events/ and the links in the event calendar are all broken.

Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block here has looks like its embedded within a light grey rectangle. That shouldn't happen

bild

The sidebar on the right does not appear in code jams 1-5 despite the page content still being narrower to accommodate for the sidebar.

Prevents page contents of events pages from being narrower when there is
no sidebar to fill the space.
This makes it consistent with the django-wiki version of the code
blocks, which looks neater.
@kosayoda kosayoda self-assigned this Mar 22, 2021
@kosayoda kosayoda requested review from MarkKoz and removed request for jerbob March 22, 2021 16:50
Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks to be in order now.

@kosayoda kosayoda merged commit 8b108bf into dewikification Mar 23, 2021
@kosayoda kosayoda deleted the ks123/dewikification/event-pages branch March 23, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants