Migrate GHCR_TOKEN -> GITHUB_TOKEN in Docker build action#472
Merged
Conversation
GITHUB_TOKEN has now enough permissions to be used for pushing to GHCR, so we don't need PAT anymore. Also, use `repository_owner` instead of the secret of username.
ks129
requested review from
Akarys42,
Den4200,
MarkKoz and
SebastiaanZ
as code owners
jb3
approved these changes
Apr 5, 2021
MarkKoz
approved these changes
Apr 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GITHUB_TOKEN has now enough permissions to be used for pushing to GHCR, so we don't need PAT anymore. Also, use
repository_ownerinstead of the secret of username.