Added Favicon#477
Closed
NeilShah2026 wants to merge 1 commit into
Closed
Conversation
HassanAbouelela
suggested changes
May 15, 2021
Contributor
HassanAbouelela
left a comment
HassanAbouelela
left a comment
There was a problem hiding this comment.
Hmm, let's stop using Imgur on our site. Can you use the asset from the github repo, or add it to the static files?
Author
|
Ok |
jb3
requested changes
May 16, 2021
Member
jb3
left a comment
jb3
left a comment
There was a problem hiding this comment.
Can we include the support for /favicon.ico in this PR as well? Or if not, open an issue to do so.
That means that devices would fallback on pages where we don't explicitly specify a favicon.
Member
|
It seems the fork this PR is based from has been deleted, so changes cannot be made. Therefore, I am closing this PR. If someone still wants to implement these changes, please open an issue for it to be discussed first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Py-Dis Logo As A Favicon For The 404 Page