Create db then switch conn, rather than use dblink#587
Closed
ChrisLovering wants to merge 1 commit into
Closed
Conversation
The previous implementation would succesfully create the metricity db, but the tables and rows would be inserted into pysite. This is because dblink doesn't switch contexts within the script, as psql doesn't support this. If we were to stick with 1 sql file, we would need to wrap every single statement into a dblink_exec() call to force psql to exec on the other db.
ChrisLovering
force-pushed
the
fix-database-switch
branch
from
2de1e72 to
84fd74e
Compare
Contributor
|
So, is this not actually an issue? |
Member
Author
Yea, this is an issue, but has been superseded by #588 since this implementation didn't work for people who also run metricity too (Since it runs it's own migrations and conflicts). See https://canary.discord.com/channels/267624335836053506/635950537262759947/885573792376709161 for an overview of what our solution is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation would succesfully create the metricity db, but the tables and rows would be inserted into pysite.
This is because dblink doesn't switch contexts within the script, as psql doesn't support this.
If we were to stick with 1 sql file, we would need to wrap every single statement into a dblink_exec() call to force psql to exec on the other db.