Alter message query to leverage index#628
Merged
Merged
Conversation
Previously this query would convert each row to an array just to check if it matched or not. By changing EXCLUDE_CHANNELS to a tuple instead of a list, it doesn't get passed as an array, so we can do a simple NOT IN check. This will also allow us to add an index with this condition to speed it up further.
|
✔️ Deploy Preview for pydis-static ready! 🔨 Explore the source changes: 5b1bb82 🔍 Inspect the deploy log: https://app.netlify.com/sites/pydis-static/deploys/619d16eb4cd8a30008a1d4ce 😎 Browse the preview: https://deploy-preview-628--pydis-static.netlify.app |
Akarys42
approved these changes
Nov 23, 2021
Contributor
Akarys42
left a comment
Akarys42
left a comment
There was a problem hiding this comment.
Let's squeeze that speed fruit. Should it be merged yet?
Member
Author
yup, it's good to be merged. I've already created the index in the db while perf testing |
jchristgit
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this query would convert each row to an array just to check if it matched or not. By changing EXCLUDE_CHANNELS to a tuple instead of a list, it doesn't get passed as an array, so we can do a simple NOT IN check.
This will also allow us to add an index with this condition to speed it up further.