Add channel ID to message deletion logs#682
Conversation
|
✔️ Deploy Preview for pydis-static ready! 🔨 Explore the source changes: 1b251d4 🔍 Inspect the deploy log: https://app.netlify.com/sites/pydis-static/deploys/62181485541c2000085be251 😎 Browse the preview: https://deploy-preview-682--pydis-static.netlify.app |
adb1f60 to
15c75c0
Compare
Add channel ID to message deletion logs
15c75c0 to
1b251d4
Compare
There was a problem hiding this comment.
Tested and it works fine and renders as you'd expect, but semantically wouldn't it make sense to not have line break within a span element, and rather split it into 2 spans?
One for the user ID, a line break, and a separate one for the line after with the timestamp and channel ID.
I would suggest:
<div class="discord-message-header">
<span class="discord-username" style="color: {{ message.author.top_role.colour | hex_colour }}">
{{ message.author }}
</span>
<span class="discord-message-metadata has-text-grey">
User ID: {{ message.author.id }}
</span>
<br>
<span class="discord-message-metadata has-text-grey">
{{ message.timestamp }} (Channel ID: {{ message.channel_id }})
</span>
</div>and in logs.css adjust the margin so it's only present on the right:
.discord-message-metadata {
font-size: 0.75rem;
font-weight: 400;
margin: 0 .3rem 0 0;
}But I realize this may be overkill, and there may also be a better way of doing this.
|
On the principle of semantics, I agree with mina. A |
|
Thanks! |
Closes #620.
The channel ID is now shown in message deletion logs.
Zoomed in on one log message:

Fullscreen page:
