Add a README for the project directory, remove unused apps#683
Conversation
|
✔️ Deploy Preview for pydis-static ready! 🔨 Explore the source changes: 9d5b0ba 🔍 Inspect the deploy log: https://app.netlify.com/sites/pydis-static/deploys/621d0255cb1f690008537d87 😎 Browse the preview: https://deploy-preview-683--pydis-static.netlify.app |
10cd5f9 to
7fd19e4
Compare
|
I'm not sure if it's a good idea to use line breaks in Markdown. I prefer to rely on soft wrapping. Otherwise one has to rely on their text editor to fix the wrapping when something gets amended (or tediously do it manually). Maybe it's fair to blame one's editor if it cannot do this easily. |
The constants module more or less did what belongs to the settings.
ecc0abb to
2e02f86
Compare
lemonsaurus
left a comment
There was a problem hiding this comment.
I like this PR. 🥇
Your documentation is good, we're simplifying some things, and generally making this project easier to work with. Nice work. Will re-review once requests are addressed.
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
lemonsaurus
left a comment
There was a problem hiding this comment.
Good, I'm 99% happy. I'll approve and leave the rest to you.
Co-authored-by: Mark <1515135+MarkKoz@users.noreply.github.com>
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
janine9vn
left a comment
There was a problem hiding this comment.
💯 This makes the project far more approachable, love this README. I now have a bit better of an idea of how to navigate this project and where to go to find what I need. No longer this black void that destroys hopes and dreams through sheer intimidation alone.
I think it would be nice here to link to site's contributing guidelines or just the landing Contributing page (https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/).
|
Thanks for the review!
I've added this in the latest commit. |
Closes #676.