Skip to content

Subclassing bot#702

Merged
Xithrius merged 35 commits into
python-discord:mainfrom
Diabolical5777:subclassing_bot
Jun 10, 2023
Merged

Subclassing bot#702
Xithrius merged 35 commits into
python-discord:mainfrom
Diabolical5777:subclassing_bot

Conversation

@Diabolical5777
Copy link
Copy Markdown
Contributor

Add detailed article on subclassing bot

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 23, 2022

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 524d1fe
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/64844c349bfe0a000898efb2
😎 Deploy Preview https://deploy-preview-702--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 23, 2022

Coverage Status

coverage: 100.0%. remained the same when pulling 524d1fe on Diabolical5777:subclassing_bot into c275a3d on python-discord:main.

@Diabolical5777
Copy link
Copy Markdown
Contributor Author

It seems I have accidentally added the subclassing HelpCommand markdown file in this PR as well, but I intended to only make a PR on subclassing Bot because I've already made a PR about subclassing the HelpCommand so please ignore that

Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Copy link
Copy Markdown
Contributor

@Shom770 Shom770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your PR! I really appreciate it. I just have a few comments, mostly regarding the style used in the code examples, so apologies in advance for the nitpicky comments haha

Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Diabolical5777 and others added 9 commits March 28, 2022 09:16
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
…sing_bot.md

Co-authored-by: Shom770 <82843611+Shom770@users.noreply.github.com>
@Diabolical5777 Diabolical5777 requested a review from Shom770 April 11, 2022 10:31
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
@Xithrius
Copy link
Copy Markdown
Contributor

Xithrius commented Jul 9, 2022

Greetings @Diabolical5777,

What's your status on this PR, and the others you've put up? Will you be finishing them?

Please see this page on making commits with great messages, to increase users' knowledge of the update history.

Thanks!

Diabolical5777 and others added 3 commits July 10, 2022 20:37
…sing_bot.md

Co-authored-by: Bluenix <bluenixdev@gmail.com>
…sing_bot.md

Co-authored-by: Bluenix <bluenixdev@gmail.com>
@Xithrius Xithrius added the area: frontend Related to site content and user interaction label Jul 31, 2022
@RohanJnr RohanJnr self-assigned this May 14, 2023
@RohanJnr RohanJnr requested review from Bluenix2 and Robin5605 May 16, 2023 17:54
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
@RohanJnr RohanJnr requested a review from shtlrs May 16, 2023 19:19
Copy link
Copy Markdown
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you so much!

Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
@RohanJnr RohanJnr requested a review from shtlrs May 17, 2023 11:54
Copy link
Copy Markdown
Contributor

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change, and we're ready to 🚢

Comment thread pydis_site/apps/content/resources/guides/python-guides/subclassing_bot.md Outdated
Copy link
Copy Markdown
Contributor

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you for finishing this one up.

@Xithrius Xithrius removed the Up for Grabs Available for anyone to work on label Jun 10, 2023
Copy link
Copy Markdown
Contributor

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. This is the remains of a review I obliterated, due to the comment being just wrong.

@Xithrius Xithrius enabled auto-merge June 10, 2023 10:10
@Xithrius Xithrius merged commit db7db22 into python-discord:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: frontend Related to site content and user interaction priority: 3 - low Low Priority type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants