Migrate on_command_error pin #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the migration of the #discord-bots pinned content from discord to the site, this PR migrates the pin regarding `on_command_error` of the discord.py library "eating" (silencing) unhandled errors.
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
18 tasks
jchristgit
requested changes
Oct 19, 2022
Member
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
This looks good, but I think we should be using four-space indents here, shouldn't we?
Uses 4 spaces for a tab rather than two, as is convention
Xithrius
added
priority: 3 - low
Xithrius
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the migration of the #discord-bots pinned content from discord to the site, this PR migrates the pin regarding
on_command_errorof the discord.py library "eating" (silencing) unhandled errors.This PR also adds a few extra items, including:
commands.BagArgumenthas been changed tocommands.MemberNotFoundelifstatement handling another error, showing users that they can handle any number of errors they want tocommands.MemberNotFound.argument,commands.MissingRequiredArgument.paramon_command_errorfunction with and without a bot subclass, as the function in itself does not do anything, and needs to be bound to the bot somehow